Make neoforge.mods.toml a generated resource, making it compatible with running from IDE #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
reviewed
Jul 11, 2024
build.gradle
Outdated
| into("build/generated/sources/modMetadata") | ||
| } | ||
| sourceSets.main.resources.srcDir(generateModMetadata) | ||
| tasks.named("neoForgeIdeSync").configure { |
There was a problem hiding this comment.
Do we want to have a nice constant for this? For example, neoForge.ideSyncTask? Not sure we want to make the exact task name API?
There was a problem hiding this comment.
Yes this line in particular I was not so keen on.
There was a problem hiding this comment.
I suppose that directly writing the task name in the script and exposing a constant for the task name in the API would be more idiomatic than my suggestion.
There was a problem hiding this comment.
Alternatively, we actually do make an api on the extension...
neoForge.runTaskOnIdeSync
It's a bit niche though
shartte
force-pushed
the
mdg-resource-gen
branch
2 times, most recently
from
ed2cd12 to
370fb31
Compare
Technici4n
reviewed
Jul 21, 2024
…th running from IDE
shartte
force-pushed
the
mdg-resource-gen
branch
from
7473eaf to
0ef7d20
Compare
Technici4n
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to this approach adds full support for placeholders in neoforge.mods.toml
In contrast to other approaches, this exposes the file where the placeholders are already replaced to the IDE as a normal source-file, meaning it is still responsible for copying it, but that also means cleaning & rebuilding from IDE has the normal intended effect, rather than it conflicting with other Gradle tasks writing to its output directory.